code review

showtime/client/src/scripts/admin.client.js

@@ -42,7 +42,7 @@ const addToList = (show,list) => {
   list.appendChild(node);
 }
 
-// fetch DELETE to delete one task with given task id
+// fetch DELETE to delete one task with given show id
 const deleteShow =
   async showId => {
     const requestOptions = {
@@ -59,7 +59,7 @@ const deleteShow =
     }
   }
 
-// fetch POST to create one task
+// fetch POST to create one show
 const createShow =
   async () => {
     const newShowData = {

showtime/client/src/scripts/user.client.js

@@ -28,7 +28,7 @@ const displayShowList = async () => {
   const requestOptions = {
     method: 'GET'
   };
-  const response = await fetch('/admin/items', requestOptions)
+  const response = await fetch('/items', requestOptions)
   if (response.ok) {
     const allShows = await response.json();
     //(ici : code  exploitation de allShows)

showtime/client/src/scripts/utils.js

-const displayList = async () => {
-    const requestOptions = {
-                             method : 'GET'
-                           };
-    const response = await fetch('/items', requestOptions)
-    const allShows = await response.json();
-  
-    //(ici : code  exploitation de allShows)
-    const list = document.getElementById('list');
-    list.textContent = '';
-    allShows.forEach( show => addToList(show, list) );
-  }
-  
-  const addToList = (show,list) => {
-  const node = document.createElement('div');
-  node.className = 'show';
-  node.textContent = `${show.description} (${show.places})`;
-  //
-  //node.addEventListener('mouseover', () => getTask(show._id));
-  //
-  const deleteButton = document.createElement('button');
-  deleteButton.className = 'ticket';
-  deleteButton.addEventListener('click', () => deleteShow(show._id));
-  deleteButton.textContent = '+1 tickets';
-  node.appendChild(deleteButton);
-  //
-  list.appendChild(node);
-  }
-
-module.exports.displayList = displayList;
-  
\ No newline at end of file

showtime/client/src/style/style.css

@@ -8,11 +8,15 @@ div {
   margin: auto;
   padding: 2px;
   text-align: center;
+  overflow: hidden;
+  box-sizing: border-box;
+  border: solid thin #999;
 }
 
 div label {
   padding: 7px;
 }
+
 input {
   text-align: center;
 }
@@ -20,6 +24,7 @@ input {
 #place {
   width: 10px;
 }
+
 button {
   padding: 3px;
   width: 100px;
@@ -28,14 +33,16 @@ button {
 }
 
 #shows, #tickets {
-  margin : 10px;
   padding: 4px;
   border: solid thin #999;
 }
 
 #list, #shows {
   padding: 2px;
-  margin : 4px 4px;
+}
+
+#list, #showTickets{
+  overflow: auto;
 }
 
 .tickets {
@@ -50,11 +57,12 @@ div.reservation:nth-of-type(even), div.show:nth-of-type(even) {
 #userdata {
   background-color: #DDD;
 }
+
 #userdata div {
   text-align: center;
   margin: 2px;
 }
+
 #controls {
   margin-top: 10px;
 }
-

showtime/server/public/style/style.css

@@ -8,11 +8,15 @@ div {
   margin: auto;
   padding: 2px;
   text-align: center;
+  overflow: hidden;
+  box-sizing: border-box;
+  border: solid thin #999;
 }
 
 div label {
   padding: 7px;
 }
+
 input {
   text-align: center;
 }
@@ -20,6 +24,7 @@ input {
 #place {
   width: 10px;
 }
+
 button {
   padding: 3px;
   width: 100px;
@@ -28,14 +33,16 @@ button {
 }
 
 #shows, #tickets {
-  margin : 10px;
   padding: 4px;
   border: solid thin #999;
 }
 
 #list, #shows {
   padding: 2px;
-  margin : 4px 4px;
+}
+
+#list, #showTickets{
+  overflow: auto;
 }
 
 .tickets {
@@ -50,11 +57,12 @@ div.reservation:nth-of-type(even), div.show:nth-of-type(even) {
 #userdata {
   background-color: #DDD;
 }
+
 #userdata div {
   text-align: center;
   margin: 2px;
 }
+
 #controls {
   margin-top: 10px;
 }
-

showtime/server/routes/admin.route.js

@@ -6,10 +6,8 @@ const authMiddleware = require('../middlewares/authentication.middleware');
 
 
 router.get('/', adminController.home );
-router.get('/me', authMiddleware.validToken, adminController.me );
-router.get('/items', authMiddleware.validToken, adminController.list);
+router.get('/items', authMiddleware.validToken, authMiddleware.isAdmin, adminController.list);
 router.post('/items', authMiddleware.validToken, authMiddleware.isAdmin, adminController.create);
 router.delete('/:showId', authMiddleware.validToken, authMiddleware.isAdmin, adminController.deleteShow);
-// router.put('/me', authMiddleware.validToken, adminController.update );
 
 module.exports = router;
\ No newline at end of file