From 8d119127b9692e5dd5ec5268e02dc4842c226909 Mon Sep 17 00:00:00 2001
From: Samuel Turpin <samuel.turpin.etu@univ-lille.fr>
Date: Tue, 28 May 2024 14:33:54 +0200
Subject: [PATCH] pmd Fixes
---
src/qdev4/Ex1.java | 4 ++--
src/tp04/PendingCaseQueue.java | 15 +++++++--------
src/tp06/Car.java | 4 ++++
src/tp06/Company.java | 5 +++--
src/tp06/TravellingSalesperson.java | 8 ++++++++
src/tp06/Vendor.java | 8 ++++++++
src/tp09/LogInManagement.java | 2 +-
src/tp09/Main.java | 14 --------------
src/tp09/WrongLoginException.java | 1 -
9 files changed, 33 insertions(+), 28 deletions(-)
delete mode 100644 src/tp09/Main.java
diff --git a/src/qdev4/Ex1.java b/src/qdev4/Ex1.java
index c55daa3..1411e88 100644
--- a/src/qdev4/Ex1.java
+++ b/src/qdev4/Ex1.java
@@ -45,9 +45,9 @@ public class Ex1
}
public static void main(String[] args) {
- int k;
try {
- k = 1/Integer.parseInt(args[0]);
+ int k = 1/Integer.parseInt(args[0]);
+ System.out.println(k);
}
catch(ArrayIndexOutOfBoundsException e) {System.err.println("Index " + e);}
catch(ArithmeticException e) {System.err.println("Arithmetic " + "");}
diff --git a/src/tp04/PendingCaseQueue.java b/src/tp04/PendingCaseQueue.java
index 66045e8..52dab47 100644
--- a/src/tp04/PendingCaseQueue.java
+++ b/src/tp04/PendingCaseQueue.java
@@ -5,7 +5,6 @@ import tpOO.tp04.PendingCase;
public class PendingCaseQueue
{
public static int CAPACITY = 10;
- private int idx;
private PendingCase[] tableur;
public PendingCaseQueue()
@@ -58,11 +57,11 @@ public class PendingCaseQueue
public double getTotalAmount()
{
double db = 0.0;
- for(int i = 0; i < this.tableur.length; i++)
+ for(PendingCase c : this.tableur)
{
- if(this.tableur[i] != null)
+ if(c != null)
{
- db = db + this.tableur[i].getAmount();
+ db = db + c.getAmount();
}
}
return db;
@@ -87,9 +86,9 @@ public class PendingCaseQueue
public boolean isEmpty()
{
int compteur = 0;
- for(int i = 0; i < this.tableur.length; i++)
+ for(PendingCase c : this.tableur)
{
- if(this.tableur[i] == null)
+ if(c == null)
{
compteur = compteur + 1;
}
@@ -105,9 +104,9 @@ public class PendingCaseQueue
public boolean isFull()
{
int compteur = 0;
- for(int i = 0; i < this.tableur.length; i++)
+ for(PendingCase c : this.tableur)
{
- if(this.tableur[i] != null)
+ if(c != null)
{
compteur = compteur + 1;
}
diff --git a/src/tp06/Car.java b/src/tp06/Car.java
index ba2e516..1eae868 100644
--- a/src/tp06/Car.java
+++ b/src/tp06/Car.java
@@ -58,6 +58,10 @@ public class Car
return purchasePrice;
}
+ public double getSalePrice() {
+ return salePrice;
+ }
+
public void setSalePrice(double salePrice)
{
this.salePrice = salePrice;
diff --git a/src/tp06/Company.java b/src/tp06/Company.java
index 3a40201..0723c19 100644
--- a/src/tp06/Company.java
+++ b/src/tp06/Company.java
@@ -2,10 +2,11 @@ package tp06;
import java.time.LocalDate;
import java.util.ArrayList;
+import java.util.List;
public class Company
{
- public static final ArrayList<Employee> EMPLOYEES = new ArrayList<>();
+ public static final List<Employee> EMPLOYEES = new ArrayList<>();
public void addEmployee(Employee e)
{
@@ -27,7 +28,7 @@ public class Company
return EMPLOYEES.size();
}
- private int getNumbClass(Class c)
+ private int getNumbClass(Object c)
{
int nb = 0;
diff --git a/src/tp06/TravellingSalesperson.java b/src/tp06/TravellingSalesperson.java
index e3dc0fe..333c9a7 100644
--- a/src/tp06/TravellingSalesperson.java
+++ b/src/tp06/TravellingSalesperson.java
@@ -12,6 +12,14 @@ public class TravellingSalesperson extends Salesperson
super(n, ld, t);
}
+ public static double getPourcentage() {
+ return POURCENTAGE;
+ }
+
+ public static int getBonus() {
+ return BONUS;
+ }
+
@Override
public String getTitle()
{
diff --git a/src/tp06/Vendor.java b/src/tp06/Vendor.java
index 2652c2e..a323994 100644
--- a/src/tp06/Vendor.java
+++ b/src/tp06/Vendor.java
@@ -12,6 +12,14 @@ public class Vendor extends Salesperson
super(n, ld, t);
}
+ public static double getPourcentage() {
+ return POURCENTAGE;
+ }
+
+ public static int getBonus() {
+ return BONUS;
+ }
+
@Override
public String getTitle()
{
diff --git a/src/tp09/LogInManagement.java b/src/tp09/LogInManagement.java
index e247a4f..77aec2d 100644
--- a/src/tp09/LogInManagement.java
+++ b/src/tp09/LogInManagement.java
@@ -14,4 +14,4 @@ public class LogInManagement
{
return true;
}
-}
+}
\ No newline at end of file
diff --git a/src/tp09/Main.java b/src/tp09/Main.java
deleted file mode 100644
index 19ecb9e..0000000
--- a/src/tp09/Main.java
+++ /dev/null
@@ -1,14 +0,0 @@
-package tp09;
-
-import java.util.Scanner;
-
-public class Main
-{
- public static void main(String[] args)
- {
- Scanner scan = new Scanner(System.in);
-
-
-
- }
-}
\ No newline at end of file
diff --git a/src/tp09/WrongLoginException.java b/src/tp09/WrongLoginException.java
index 7d85efc..49fd0c3 100644
--- a/src/tp09/WrongLoginException.java
+++ b/src/tp09/WrongLoginException.java
@@ -5,7 +5,6 @@ public class WrongLoginException extends Exception
@Override
public synchronized Throwable initCause(Throwable cause)
{
-
return super.initCause(cause);
}
}
\ No newline at end of file
--
GitLab